Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebay-tooltip: update colors #2524

Closed
3 tasks done
randybascue opened this issue Jan 14, 2025 · 0 comments
Closed
3 tasks done

ebay-tooltip: update colors #2524

randybascue opened this issue Jan 14, 2025 · 0 comments
Assignees
Labels
design system Requested by the design system size: 1 type: enhancement
Milestone

Comments

@randybascue
Copy link

Description

Problem

The tooltip currently has a white background with black foreground content. However, it should match the tourtips with a darker background and white foreground content.

Solution

Update the tooltip background and foreground colors to resemble the tourtip styling

Acceptance criteria

  1. The tooltip background uses --color-background-inverse
  2. The tooltip text uses --color-foreground-on-inverse

Screenshots

image

Figma link

https://www.figma.com/design/zEBdEhbonrBOGzZ0fXzWvM/branch/8s8YNs3MPECIt2Xa8qTcba/eBay-Evo-Design-System?node-id=254096-47528&t=Nlvyi9ndskQ4j1Pn-11

Engineering pre-requisites

  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
@agliga agliga added this to eBayUI Jan 31, 2025
@agliga agliga added this to the 19.1.0 milestone Jan 31, 2025
@agliga agliga added the design system Requested by the design system label Jan 31, 2025
@agliga agliga moved this to Todo in eBayUI Jan 31, 2025
@ArtBlue ArtBlue moved this from Todo to In Progress in eBayUI Feb 5, 2025
@ArtBlue ArtBlue moved this from In Progress to Pull request in eBayUI Feb 5, 2025
@ArtBlue ArtBlue moved this from Pull request to Done in eBayUI Feb 6, 2025
@ArtBlue ArtBlue closed this as completed by moving to Done in eBayUI Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design system Requested by the design system size: 1 type: enhancement
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants