Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mult rows need to be pasted into multiple cells #4319

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 16, 2024

close https://github.com/dream-num/univer-pro/issues/2475

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested a review from yuhongz as a code owner December 16, 2024 11:52
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 16, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  8f46849
info  For more information, see full report

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.45%. Comparing base (a1da277) to head (8f46849).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...ui/src/services/clipboard/html-to-usm/converter.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4319      +/-   ##
==========================================
- Coverage   33.55%   33.45%   -0.10%     
==========================================
  Files        2505     2509       +4     
  Lines      129102   129496     +394     
  Branches    28896    28972      +76     
==========================================
+ Hits        43314    43329      +15     
- Misses      85788    86167     +379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7
Copy link

@ybzky第3行粘贴后未识别为链接,3、4行少了一个字符
image

@univer-bot
Copy link

univer-bot bot commented Dec 17, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@ybzky The 3rd line is not recognized as a link after pasting, and there is one character missing in lines 3 and 4.
image

Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Dec 18, 2024
@ybzky ybzky merged commit 17a92a8 into dev Dec 18, 2024
9 checks passed
@ybzky ybzky deleted the fix-mult-line-paste branch December 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants