Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow changes in CORS settings #100

Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix: allow changes in CORS settings #100

merged 1 commit into from
Mar 17, 2025

Conversation

dolfim-ibm
Copy link
Contributor

Expose CORS parameters as ENV variables, e.g.

DOCLING_SERVE_CORS_ORIGINS='["localhost"]' docling-serve run

Because of what was found in #99, it is better to expose the parameter only as ENV.

Issue resolved by this Pull Request:
Resolves #88

@dolfim-ibm dolfim-ibm mentioned this pull request Mar 15, 2025
4 tasks
Copy link

mergify bot commented Mar 15, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@dolfim-ibm dolfim-ibm merged commit 422c402 into main Mar 17, 2025
9 checks passed
@dolfim-ibm dolfim-ibm deleted the fix-expose-cors branch March 17, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix runtime parameters
3 participants