Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ellipse radius in Precland/Ring_Detector.py#L213 & L220 are wrong #4

Open
gluca opened this issue Jan 9, 2017 · 0 comments
Open

ellipse radius in Precland/Ring_Detector.py#L213 & L220 are wrong #4

gluca opened this issue Jan 9, 2017 · 0 comments

Comments

@gluca
Copy link

gluca commented Jan 9, 2017 •
edited
Loading

the radius calculated in Ring_Detector.py is wrong, it should be

radius = int((ellipse[1][0] + ellipse[1][1]) /4.0)

and not

radius = int((ellipse[1][0] + ellipse[1][0]) /4.0)

same error in L220 but less important because you are assuming the ellipse is a "circle"
@gluca gluca changed the title ellipse radius in Precland/Ring_Detector.py#L213 is wrong ellipse radius in Precland/Ring_Detector.py#L213 & L220 are wrong Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gluca