Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drift alerts as issues #715

Open
ZIJ opened this issue Oct 31, 2023 · 2 comments
Open

Drift alerts as issues #715

ZIJ opened this issue Oct 31, 2023 · 2 comments
Labels
enhancement New feature or request user-reported

Comments

@ZIJ
Copy link
Contributor

ZIJ commented Oct 31, 2023

Currently, Digger sends drift alerts via Slack only. This however makes them just FYI - there is no way to trace what happens to each alert, other than threads or emoji reactions.

User suggestion: create GitHub issues for drift alerts instead. This way it can be tracked, or explicitly closed.

Considerations:

Q1: how many alerts?

  • Option 1: a separate issue for each project
  • Option 2: an aggregate issue for the entire repo

Q2: what to do with outdated issues?

Say drift detection ran, and an issue was created. No one did anything about it. The next day, more drift happened. Now there is another issue with more up-to-date drift info.

  • Option 1: automatically close outdated issues (all? or only the immediately preceding one? or only ones that don't have user activity?)
  • Option 2: keep them open (perhaps add comments linking to the newest version)

Proposed approach (subject to change) - Option 1 on Q1, Option 1 on Q2

  • On every run, an issue is created for each project that has drift detected
  • If there are older issues with drift for the same project: if it has discussions or open PRs, a comment is added and it is marked as duplicate; if it doesn't have any activity, it is closed
@ZIJ ZIJ added enhancement New feature or request user-reported labels Oct 31, 2023
@maciej-ciach
Copy link

I like the idea of separate issues for each project.

Each issue contains SINGLE comment that is updated with the most recent drift to reflect the latest drift state.

Issue deletion should be handled manually, not by the digger itself.

@ZIJ ZIJ mentioned this issue Jan 29, 2024
@ZIJ
Copy link
Contributor Author

ZIJ commented Mar 4, 2024

Issue creation added in #1239
Keeping this open for now because we'd also need to add updating and closing logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user-reported
Projects
None yet
Development

No branches or pull requests

2 participants