Skip to content

Commit 25b3b91

Browse files
committed
fix: improve error caching behavoir (#2211)
This commit ensures that the GraphQL Pat error is not cached in any browser. See anuraghazra/github-readme-stats#1471 (comment).
1 parent b7b0f37 commit 25b3b91

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

api/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export default async (req, res) => {
8989
}),
9090
);
9191
} catch (err) {
92-
res.setHeader("Cache-Control", `no-store`); // Don't cache error responses.
92+
res.setHeader("Cache-Control", `no-cache, no-store, must-revalidate`); // Don't cache error responses.
9393
return res.send(renderError(err.message, err.secondaryMessage));
9494
}
9595
};

api/pin.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export default async (req, res) => {
7575
}),
7676
);
7777
} catch (err) {
78-
res.setHeader("Cache-Control", `no-store`); // Don't cache error responses.
78+
res.setHeader("Cache-Control", `no-cache, no-store, must-revalidate`); // Don't cache error responses.
7979
return res.send(renderError(err.message, err.secondaryMessage));
8080
}
8181
};

api/top-langs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export default async (req, res) => {
7676
}),
7777
);
7878
} catch (err) {
79-
res.setHeader("Cache-Control", `no-store`); // Don't cache error responses.
79+
res.setHeader("Cache-Control", `no-cache, no-store, must-revalidate`); // Don't cache error responses.
8080
return res.send(renderError(err.message, err.secondaryMessage));
8181
}
8282
};

api/wakatime.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export default async (req, res) => {
7878
}),
7979
);
8080
} catch (err) {
81-
res.setHeader("Cache-Control", `no-store`); // Don't cache error responses.
81+
res.setHeader("Cache-Control", `no-cache, no-store, must-revalidate`); // Don't cache error responses.
8282
return res.send(renderError(err.message, err.secondaryMessage));
8383
}
8484
};

tests/api.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ describe("Test /api/", () => {
180180

181181
expect(res.setHeader.mock.calls).toEqual([
182182
["Content-Type", "image/svg+xml"],
183-
["Cache-Control", `no-store`],
183+
["Cache-Control", `no-cache, no-store, must-revalidate`],
184184
]);
185185
});
186186

0 commit comments

Comments
 (0)