Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minogrpc: Watch for certificate updates #220

Open
nkcr opened this issue Jul 26, 2022 · 0 comments
Open

Minogrpc: Watch for certificate updates #220

nkcr opened this issue Jul 26, 2022 · 0 comments
Labels
mod/mino About the Mino module

Comments

@nkcr
Copy link
Contributor

nkcr commented Jul 26, 2022

Minogrpc uses a DiskStore to store its own certificate. The DiskStore uses the InMemoryStore as a caching layer, which prevents certificates from being loaded each time from the disk. While performant, this caching layer prevents the node from loading an updated certificate.

Possible solutions:

  1. Update the DiskStore to watch the server certificate file and reload it once it changes. For example with https://github.com/fsnotify/fsnotify.

  2. Update the InMemoryStore to add an expiration time on elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod/mino About the Mino module
Projects
None yet
Development

No branches or pull requests

1 participant