Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify-cms-core react dependency #2673

Closed
boombang opened this issue Sep 11, 2019 · 2 comments
Closed

netlify-cms-core react dependency #2673

boombang opened this issue Sep 11, 2019 · 2 comments

Comments

@boombang
Copy link

boombang commented Sep 11, 2019

Describe the bug
According to https://www.netlifycms.org/blog/2019/07/netlify-cms-gatsby-plugin-4-0-0/ instead of netlify-cms we need to use netlify-cms-app package as it has React as a peer dependency. But netlify-cms-app also has netlify-cms-core dependency https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-app/package.json#L33 which has React as a dependency, not a peer one https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-core/package.json#L39
Because of that I still have multiple instances of React.

Expected behavior
In the package.json of netlify-cms-core react is set as a peer dependency

Screenshots
image

@talves
Copy link
Collaborator

talves commented Sep 11, 2019

@boombang Great catch, but luckily is is also specified in the peer dependencies, so the bundler picks it up during the build process and ignores the dependency and treats it as an external. Are you seeing an error for a duplicate React instance otherwise?

If you want, you can submit a quick PR with the dependency removed. Thanks.

@martinjagodic
Copy link
Member

Closing as stale and/or outdated.

@martinjagodic martinjagodic closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants