Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to add characters and possibly movie source? #3

Open
jybleau opened this issue Jul 18, 2024 · 0 comments
Open

PR to add characters and possibly movie source? #3

jybleau opened this issue Jul 18, 2024 · 0 comments

Comments

@jybleau
Copy link

jybleau commented Jul 18, 2024

Hello @dcgauld
Would you accept a non breaking PR to add the character's name for each quotes?

Maybe add the source movie too...

Existing functions would still work as is.
Would probably add something like starwars.withCharacter() (likewise for the CLI)

tx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jybleau