Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using internal AnalysisContextCollectionImpl #4018

Open
scheglov opened this issue Mar 18, 2025 · 2 comments
Open

Stop using internal AnalysisContextCollectionImpl #4018

scheglov opened this issue Mar 18, 2025 · 2 comments
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@scheglov
Copy link
Contributor

scheglov commented Mar 18, 2025

According to #2566 the saving is less than 5%.
This is way less than I think is necessary to justify using internal APIs.

@srawlins
Copy link
Member

I'd love for this API to be public.

@srawlins srawlins added P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable labels Mar 18, 2025
@bwilkerson
Copy link
Member

But it might justify enhancing the public API so that we can retain the performance improvement while still avoiding public API.

The need here is to disable the generation of warnings and lints. But another soon-to-be-needed control is to disable running plugins. I don't think we want to completely disable the use of analysis options, but I'm not sure what the right nobs are for controlling the analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

3 participants