Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public,max-age=31536000, immutable #424

Closed
enricoschaaf opened this issue Dec 19, 2023 · 2 comments · Fixed by #430
Closed

public,max-age=31536000, immutable #424

enricoschaaf opened this issue Dec 19, 2023 · 2 comments · Fixed by #430

Comments

@enricoschaaf
Copy link

enricoschaaf commented Dec 19, 2023

Hi 👋

I am using Souin through Caddy and I noticed that a public,max-age=31536000, immutable cache control response header from the origin gets cached for 120 seconds (the default ttl) instead based on the max age?

Is this a bug or something that can be configured?

Thanks for providing a way to run a cache alongside caddy :)

@darkweak
Copy link
Owner

Hello @enricoschaaf sorry for this long time without answer.

I think that's a bug, I put your issue on my debug-todo list. Maybe I could write a patch this weekend but not guaranteed.

Thank you for your feedback, I keep you updated on that.

@darkweak
Copy link
Owner

@enricoschaaf We store the response for the min between max-age response directive and the ttl defined in the configuration (default 120s). A solution could be to increase the default ttl directive but I'm wondering if we have to keep the actual behavior or remove this duration calculation. I don't think the rfc specifies something about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants