internal/core/adt: do not free vertex

We haven't implemented memory management yet
so do not try to do this. In some cases, it leads to
a nil node, leading to a crash.

The fact that some of the counters change is
already quite suspicious.

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Ie2b10b3c428d32e6c4156317f8da0225fcf540d1
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207171
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>

Author: mpvl

cue/testdata/benchmarks/disjunctelim.txtar

@@ -40,10 +40,10 @@ issue3610: {
 }
 
 -- out/evalalpha/stats --
-Leaks:  572
-Freed:  230
-Reused: 230
-Allocs: 572
+Leaks:  612
+Freed:  190
+Reused: 190
+Allocs: 612
 Retain: 0
 
 Unifications: 22
@@ -58,10 +58,10 @@ diff old new
 -Freed:  367
 -Reused: 356
 -Allocs: 11
-+Leaks:  572
-+Freed:  230
-+Reused: 230
-+Allocs: 572
++Leaks:  612
++Freed:  190
++Reused: 190
++Allocs: 612
  Retain: 0
 
 -Unifications: 133

cue/testdata/benchmarks/disjunction.txtar

@@ -146,10 +146,10 @@ x: a0: {}
   }
 }
 -- out/evalalpha/stats --
-Leaks:  158
-Freed:  4
-Reused: 4
-Allocs: 158
+Leaks:  162
+Freed:  0
+Reused: 0
+Allocs: 162
 Retain: 0
 
 Unifications: 6
@@ -164,10 +164,10 @@ diff old new
 -Freed:  82
 -Reused: 74
 -Allocs: 8
-+Leaks:  158
-+Freed:  4
-+Reused: 4
-+Allocs: 158
++Leaks:  162
++Freed:  0
++Reused: 0
++Allocs: 162
  Retain: 0
 
 -Unifications: 4

cue/testdata/benchmarks/issue1684.txtar

@@ -62,10 +62,10 @@ nestedClosed: passing: {
 	D: {id: {}} | {[string]: D}
 }
 -- out/evalalpha/stats --
-Leaks:  2135
-Freed:  658
-Reused: 658
-Allocs: 2135
+Leaks:  2140
+Freed:  653
+Reused: 653
+Allocs: 2140
 Retain: 0
 
 Unifications: 475
@@ -143,10 +143,10 @@ diff old new
 -Freed:  1064333
 -Reused: 1064282
 -Allocs: 51
-+Leaks:  2135
-+Freed:  658
-+Reused: 658
-+Allocs: 2135
++Leaks:  2140
++Freed:  653
++Reused: 653
++Allocs: 2140
  Retain: 0
 
 -Unifications: 792123

cue/testdata/benchmarks/listdedup.txtar

@@ -33,10 +33,10 @@ C: #steps: #Script & {mount: [B]}
 
 #ref: {a: 1} | {b: 2}
 -- out/evalalpha/stats --
-Leaks:  158
-Freed:  10
-Reused: 10
-Allocs: 158
+Leaks:  168
+Freed:  0
+Reused: 0
+Allocs: 168
 Retain: 0
 
 Unifications: 56
@@ -545,10 +545,10 @@ diff old new
 -Reused: 24051
 -Allocs: 45
 -Retain: 1
-+Leaks:  158
-+Freed:  10
-+Reused: 10
-+Allocs: 158
++Leaks:  168
++Freed:  0
++Reused: 0
++Allocs: 168
 +Retain: 0
 
 -Unifications: 18724

cue/testdata/eval/conjuncts.txtar

@@ -69,10 +69,10 @@ issue2355: {
 }
 
 -- out/evalalpha/stats --
-Leaks:  216
-Freed:  30
-Reused: 30
-Allocs: 216
+Leaks:  246
+Freed:  0
+Reused: 0
+Allocs: 246
 Retain: 0
 
 Unifications: 43
@@ -163,10 +163,10 @@ diff old new
 -Reused: 59
 -Allocs: 18
 -Retain: 22
-+Leaks:  216
-+Freed:  30
-+Reused: 30
-+Allocs: 216
++Leaks:  246
++Freed:  0
++Reused: 0
++Allocs: 246
 +Retain: 0
 
 -Unifications: 45

cue/testdata/eval/notify.txtar

@@ -1596,10 +1596,10 @@ Result:
   }
 }
 -- out/evalalpha/stats --
-Leaks:  2249
-Freed:  266
-Reused: 265
-Allocs: 2250
+Leaks:  2262
+Freed:  253
+Reused: 252
+Allocs: 2263
 Retain: 0
 
 Unifications: 760
@@ -1615,10 +1615,10 @@ diff old new
 -Reused: 85
 -Allocs: 46
 -Retain: 5
-+Leaks:  2249
-+Freed:  266
-+Reused: 265
-+Allocs: 2250
++Leaks:  2262
++Freed:  253
++Reused: 252
++Allocs: 2263
 +Retain: 0
 
 -Unifications: 48

internal/core/adt/disjunct2.go

@@ -634,7 +634,7 @@ outer:
 		if x.defaultMode == isDefault {
 			xn.defaultMode = isDefault
 		}
-		x.free()
+		// TODO: x.free()
 		return a
 	}