encoding/jsonschema: fail on mismatched error messages

rogpeppe · rogpeppe · commit 09c9ccaec481 · 2025-01-14T13:33:04.000Z
This means that CI will fail when the encoding/jsonschema error messages change so the error messages will not get out of step with the actual messages being produced, and developers can run `CUE_UPDATE=1 go test ./...` without the encoding/jsonschema tests failing all the time. Signed-off-by: Roger Peppe <rogpeppe@gmail.com> Change-Id: I4ebee17e1cacc26e12bbc5eef2e36a511d3c16cb Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207148 TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
diff --git a/encoding/jsonschema/external_test.go b/encoding/jsonschema/external_test.go
@@ -218,6 +218,7 @@ func testFailed(t *testing.T, m *cuetdtest.M, skipField *externaltest.Skip, p po
 		return
 	}
 	if reason := (*skipField)[m.Name()]; reason != "" {
+		qt.Assert(t, qt.Equals(reason, errStr), qt.Commentf("error message mismatch"))
 		t.Skipf("skipping due to known error: %v", reason)
 	}
 	t.Fatal(errStr)

Original file line number	Diff line number	Diff line change
`@@ -218,6 +218,7 @@ func testFailed(t testing.T, m cuetdtest.M, skipField *externaltest.Skip, p po`
`218`	`218`	`return`
`219`	`219`	`}`
`220`	`220`	`if reason := (*skipField)[m.Name()]; reason != "" {`
	`221`	`+ qt.Assert(t, qt.Equals(reason, errStr), qt.Commentf("error message mismatch"))`
`221`	`222`	`t.Skipf("skipping due to known error: %v", reason)`
`222`	`223`	`}`
`223`	`224`	`t.Fatal(errStr)`