You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Languages with dialects (pt-BR) aren't downloading (it might be only for Crowdin Enterprise)
To Reproduce
Steps to reproduce the behavior:
Set pt-BR language in the app
Start the app
See that strings aren't downloaded
Expected behavior
Expected to download it as different languages
Screenshots
Smartphone (please complete the following information):
Device: iPhone 12 Pro
OS: iOS 16.4
Additional context
Languages with dialects are denoted with a hyphen (pt-BR), and locales are denoted with an underscore (pt_BR).
There seems to be a confusion of these two concepts in the SDK at the stage of adding downloadable languages to CrowdinRemoteLocalisationStorage.
The final stage where the error occurs is the ManifestManager.iOSLanguageCode(for:) method, because it takes the locale code instead of the language code.
Describe the bug
Languages with dialects (
pt-BR
) aren't downloading (it might be only for Crowdin Enterprise)To Reproduce
Steps to reproduce the behavior:
pt-BR
language in the appExpected behavior
Expected to download it as different languages
Screenshots

Smartphone (please complete the following information):
Additional context
Languages with dialects are denoted with a hyphen (pt-BR), and locales are denoted with an underscore (pt_BR).
There seems to be a confusion of these two concepts in the SDK at the stage of adding downloadable languages to
CrowdinRemoteLocalisationStorage
.The final stage where the error occurs is the
ManifestManager.iOSLanguageCode(for:)
method, because it takes the locale code instead of the language code.I think it makes sense to replace the
osxLocale
withiOSLanguageCode
to fix that.The text was updated successfully, but these errors were encountered: