Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading dark background causes sporadic performance issues #86

Open
orlangure opened this issue Jun 8, 2022 · 1 comment
Open
Labels
bug Something isn't working
Milestone

Comments

@orlangure
Copy link

Commit b3934f5 for some reason started causing major sporadic performance issues in my environment: the call to HasDarkBackground sometimes takes up to one minute to complete. About 50% of the time everything runs smoothly, and other 50% it gets stuck for at least a couple of seconds.

When checking out to v0.5.0 and running git revert b3934f5, the problem disappears. The issue exists on master as well.

My environment:
Alacritty 0.10.1
Tmux 3.3
Macos 12.4

@muesli muesli added the bug Something isn't working label Oct 5, 2022
@muesli
Copy link
Contributor

muesli commented Oct 5, 2022

Thanks for creating the issue. This is a timing issue, where both tea and lipgloss try to query the background color from the terminal. We have a fix for this in the next releases of both tea and lipgloss!

@bashbunni bashbunni added this to the v2.0.0 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants