Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable toolbar #64

Closed
btzr-io opened this issue Oct 19, 2019 · 3 comments
Closed

Customizable toolbar #64

btzr-io opened this issue Oct 19, 2019 · 3 comments

Comments

@btzr-io
Copy link
Owner

btzr-io commented Oct 19, 2019

Current set of options for toolbar is really limited, see https://github.com/btzr-io/Villain#options
We should provide and option to customize the toolbar elements.

Possible solutions and ideas

  • Create an allowFeature.. props for each tool / feature
  • Create a prop to choose what toolbar actions will be shown: actions: ['fullscreen' , ...]
  • Maybe another one to block actions: blockActions: ['fullscreen',...]
  • Add custom buttons ? buttons: [ { name: 'flip', action: (e) => something... } ]

Open for suggestions.

@DaniAcu
Copy link
Contributor

DaniAcu commented Dec 28, 2019

Maybe we could try with another pattern to be more reusable. For example, the final use could be...

<Villain>
<Villian.Button prop={value}></Villian.Button>
</Villian>

I don't know, how are some of the final cases that you are thinking, maybe if you could help me with vision or more context I could help with more robust ideas. 😜

@btzr-io
Copy link
Owner Author

btzr-io commented Dec 29, 2019

I like that approach, not sure how easy will be to integrate due the current structure / state management.

@btzr-io btzr-io mentioned this issue Sep 7, 2020
16 tasks
@btzr-io btzr-io added this to the v2.0.0 milestone Sep 7, 2020
@btzr-io
Copy link
Owner Author

btzr-io commented Sep 7, 2020

Thanks to the new hooks-api it is now possible to make your own toolbar or any external component.
There there will still be one provided as a default option and example.

@btzr-io btzr-io closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants