-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ebooks integration #230
Comments
I’m super excited to take it. Assign me if you want |
Awesome. Let me spike that on this week and share some ideas about how start with that |
I tried many ideas and read a lot. So now I think that we could use a Factory. Check this sample and tell me if you are agree with that and I could start implementing that. https://sourcemaking.com/design_patterns/factory_method/java/1 |
@DaniAcu Looks interesting, sure feel free to open a PR, let me know if you have more questions or need any help ✌️ |
Thanks maybe if you have some documentation about how works the renderer or some overview could be helpful. |
The render is just a react component for Ebooks shouldn't use this anyway. |
I was looking into all the code. |
Epub is not supported yet, thats why I open this issue to track development of more ebook formats like |
The priority is to support comic-archive files, but if we could extend the support to other files / formats that will be great. Maybe as a plugin or extension if is not a viable option to add it in the main repo. |
This definitely should be a plugin or extension, not priority, I'll close this for now. |
What other formats should this support besides compressed archives ?
I think
epub
is a good option,pdf
is also commonly used but it wont be a optimized for text content, just images.Possible solution
https://github.com/mozilla/pdf.js
https://github.com/futurepress/epub.js/
The text was updated successfully, but these errors were encountered: