We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link component should be allowed to render <button so that we can avoid developers using <Link href="#".
<button
<Link href="#"
This plan is approved by @AlanBreck and @fallaciousreasoning
The text was updated successfully, but these errors were encountered:
plain-html
This should involve rendering a
<svelte:element this={isButton ? 'button' : 'a'}> ... </svelte:element>
https://learn.svelte.dev/tutorial/svelte-element
Sorry, something went wrong.
Instead of svelte:element, would it not be easier to pull in https://github.com/brave/leo/blob/main/src/components/button/button.svelte to return an actual button when isButton is set/true? Otherwise, it seems we'll have quite a bit of work to maintain button-aesthetics across the two components.
svelte:element
isButton
I think the point of this one is to not maintain the button aesthetics - it should always look like a link here
petemill
No branches or pull requests
Link component should be allowed to render
<button
so that we can avoid developers using<Link href="#"
.This plan is approved by @AlanBreck and @fallaciousreasoning
The text was updated successfully, but these errors were encountered: