Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download of PDFs via HTTPS #124

Open
fhamborg opened this issue May 1, 2017 · 3 comments
Open

Download of PDFs via HTTPS #124

fhamborg opened this issue May 1, 2017 · 3 comments
Milestone

Comments

@fhamborg
Copy link

fhamborg commented May 1, 2017

I couldnt find an option in the settings pane to enable/force download via HTTPS. Is there a possibility to do this somewhere? Where in the code would that need to be changed? I'd gladly provide a patch for that if you could point me to where to start.

@bpiwowar
Copy link
Owner

bpiwowar commented May 2, 2017

Hi, no there is no option to do so.

If you want to force this, you have to modify the function getDataFile : the WP_CONTENT_URL contains the base URL; you should thus replace the prefix.

If you want to submit a patch, please provide an option (just look at the occurrences of the use_files option) to turn this off or on.

@bpiwowar bpiwowar added this to the 0.5.x milestone May 2, 2017
@fhamborg
Copy link
Author

fhamborg commented May 4, 2017

I've added corresponding adaptions to papercite.php. Is there any other file, which requires further adaptions? I had a look at the papercite_options.php but couldn't find your example of use_files in there, so I guess not?

@fhamborg
Copy link
Author

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants