Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from dictionaries to initialise DataObjectMixin classes #295

Open
jonnyh404 opened this issue Mar 19, 2024 · 0 comments
Open

Move away from dictionaries to initialise DataObjectMixin classes #295

jonnyh404 opened this issue Mar 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jonnyh404
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Entering a dict isn't intuitive and should be entered by named parameters instead. We should keep initialisation by dict as a "from_dict" classmethod.

Describe the solution you'd like
Remove the dict from the DataObjectMixin init. Update all derived classes to have a named parameter for all possible keywords in the keyword mapping dicts.

@jonnyh404 jonnyh404 added the enhancement New feature or request label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant