Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SpecialUsers enum with full Principal object #923

Open
DiamondJoseph opened this issue Mar 12, 2025 · 0 comments
Open

Replace SpecialUsers enum with full Principal object #923

DiamondJoseph opened this issue Mar 12, 2025 · 0 comments

Comments

@DiamondJoseph
Copy link
Contributor

Adding type hints to where get_current_principal is used, there are special cases to consider with SpecialUsers. If the SpecialUsers were instead Principal objects, this special handling could be removed.

i.e. replace

SpecialUsers(str, Enum):
    admin = "admin"
    public = "public"

# with

admin = Principal(roles=...)
public = Principal(roles=...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant