Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Briefcase data directory is still being mounted in to containers for brutus user when root is used #1374

Closed
rmartin16 opened this issue Jul 22, 2023 · 2 comments · Fixed by #1390
Labels
bug A crash or error in behavior. linux The issue relates Linux support.

Comments

@rmartin16
Copy link
Member

Describe the bug

With #1331, the user in Docker containers can now be root as well as brutus; however, Briefcase always mounts the data directory in to .cache directory for brutus. This doesn't appear to be having adverse effects right now....but it should probably be reconciled.

Steps to reproduce

  1. Using Docker Desktop, run briefcase open linux --target debian
  2. Run whoami to see current user
  3. Run ls -lh /home/brutus/.cache/

Expected behavior

I suppose it doesn't actually hurt anything to leave this as is....but it seems a lot more consistent if we use a user-agnostic location to bind mount the Briefcase data directory given we're not always using the brutus user now.

Screenshots

No response

Environment

  • Operating System: pop os 22.04
  • Python version: 3.10.12
  • Software versions:
    • Briefcase: 0.3.16.dev20+g8b020d6c

Logs

No response

Additional context

No response

@rmartin16 rmartin16 added bug A crash or error in behavior. linux The issue relates Linux support. labels Jul 22, 2023
@freakboy3742
Copy link
Member

@rmartin16 AFAICT, this should have been fixed by beeware/briefcase-linux-system-template#7 and beeware/briefcase-linux-appimage-template#34 - am I correct, or is there something else going on here? If it is fixed, do we need to add changenote-only PR to announce the bug fix?

@rmartin16
Copy link
Member Author

This is a little different; here, I'm pointing out that we're still using /home/brutus/.cache/briefcase when the brutus user does not exist in the image; such as when using Docker Desktop on Linux and root is used in the image.

It's not an inherent problem....it's just a bit strange...especially without any context/history.

I think a more consistent approach would put the Briefcase data directory in root's home directory in this case or use a dedicated location in the filesystem like /briefcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior. linux The issue relates Linux support.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants