feat(go): add jsii.Sprintf helper #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a fairly common practice to compose string values using `fmt.Sprintf`, however in order to use these with `jsii` they need to be stored into a variable so a pointer can be taken from them, or they need passed into the `jsii.String` function. This new helper removes this constraint and provides a simple way to perform `jsii`-friendly string interpolation.
RomainMuller
changed the title
MrArnoldPalmer
approved these changes
Nov 21, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
MrArnoldPalmer
approved these changes
Nov 24, 2023
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a fairly common practice to compose string values using
fmt.Sprintf, however in order to use these withjsiithey need to be stored into a variable so a pointer can be taken from them, or they need passed into thejsii.Stringfunction.This new helper removes this constraint and provides a simple way to perform
jsii-friendly string interpolation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.