Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for Python 3.6 (EOL as of 2021-12-23) #3472

Merged
merged 8 commits into from
Apr 25, 2022

Conversation

RomainMuller
Copy link
Contributor

Python 3.6 has been end-of-life since late december 2021, and an
increasing amount of our dependencies are dropping support for it as a
consequence.

We introduced a warning to users that are still using Python 3.6 with
release v1.55.1 around March 16, 2022.

We are now effectively dropping support for Python 3.6, and introducing
testing for Python 3.10 releases.

Related: 919f735

BREAKING CHANGE: jsii-pacmak and the libraries it generates for Python
targets now require a minimum Python version of 3.7, instead of 3.6
previously. We recommend users upgrade to the latest supported Python
release (Python 3.10).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Python 3.6 has been end-of-life since late december 2021, and an
increasing amount of our dependencies are dropping support for it as a
consequence.

We introduced a warning to users that are still using Python 3.6 with
release `v1.55.1` around March 16, 2022.

We are now effectively dropping support for Python 3.6, and introducing
testing for Python 3.10 releases.

Related: 919f735

BREAKING CHANGE: `jsii-pacmak` and the libraries it generates for Python
targets now require a minimum Python version of 3.7, instead of 3.6
previously. We recommend users upgrade to the latest supported Python
release (Python 3.10).
@RomainMuller RomainMuller added the pr/do-not-merge This PR should not be merged at this time. label Apr 5, 2022
@RomainMuller RomainMuller requested a review from a team April 5, 2022 11:43
@RomainMuller RomainMuller self-assigned this Apr 5, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 5, 2022
@RomainMuller
Copy link
Contributor Author

⚠️ This PR should remain labeled with pr/do-not-merge at least until 2022-04-16 (at which point it'll have bee a full month since we released the first version of jsii that emits a deprecation warning to users still on Python 3.6).

Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when we are rdy.

@RomainMuller
Copy link
Contributor Author

RomainMuller commented Apr 14, 2022

ℹ️ Important Information

This PR removes some PR check builds that are currently required by the branch protection settings for the main and release branches. This means this PR will not be merge-able by Mergify until the branch protection settings are updated to:

  1. Remove all 9 builds using Python 3.6 from requirements
  2. Add the 8 new Python 3.7 builds to requirements
    • There is one less than was removed due to Python 3.7 being part of the previous Python test matrix already
  3. Add the Python 3.10 build (there is only 1) to requirements (this PR has Mergify updated to wait for those before merging, but GitHub branch protection should also require them)

When this update is done, all existing PRs will fail to pass PR validation rules until they are updated to the new master HEAD.

@RomainMuller RomainMuller removed the pr/do-not-merge This PR should not be merged at this time. label Apr 25, 2022
@RomainMuller RomainMuller merged commit abf7415 into main Apr 25, 2022
@RomainMuller RomainMuller deleted the rmuller/python-3.7 branch April 25, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants