Skip to content

Commit 3710b78

Browse files
rix0rrrgithub-actions
and
github-actions
authoredMar 4, 2025··
fix: don't show built-in Node lifetime warnings (#186)
We have moved to using Notices to display Node support warnings, so we should disable the built-in warnings provided by `@jsii/check-node`. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
1 parent faa2de0 commit 3710b78

File tree

13 files changed

+3
-33
lines changed

13 files changed

+3
-33
lines changed
 

‎.projenrc.ts

-2
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,6 @@ const cli = configureProject(
771771
cloudFormationDiff,
772772
cxApi,
773773
'@aws-cdk/region-info',
774-
'@jsii/check-node',
775774
'archiver',
776775
...CLI_SDK_VERSION === '2' ? [
777776
'aws-sdk',
@@ -1136,7 +1135,6 @@ const toolkitLib = configureProject(
11361135
`@aws-sdk/credential-providers@${CLI_SDK_V3_RANGE}`,
11371136
`@aws-sdk/ec2-metadata-service@${CLI_SDK_V3_RANGE}`,
11381137
`@aws-sdk/lib-storage@${CLI_SDK_V3_RANGE}`,
1139-
'@jsii/check-node',
11401138
'@smithy/middleware-endpoint',
11411139
'@smithy/node-http-handler',
11421140
'@smithy/property-provider',

‎packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES

-7
Original file line numberDiff line numberDiff line change
@@ -11118,13 +11118,6 @@ Apache License
1111811118
limitations under the License.
1111911119

1112011120

11121-
----------------
11122-
11123-
** @jsii/check-node@1.108.0 - https://www.npmjs.com/package/@jsii/check-node/v/1.108.0 | Apache-2.0
11124-
jsii
11125-
Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
11126-
11127-
1112811121
----------------
1112911122

1113011123
** @smithy/abort-controller@4.0.1 - https://www.npmjs.com/package/@smithy/abort-controller/v/4.0.1 | Apache-2.0

‎packages/@aws-cdk/toolkit-lib/.projen/deps.json

-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/@aws-cdk/toolkit-lib/.projen/tasks.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/@aws-cdk/toolkit-lib/package.json

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/aws-cdk/.projen/deps.json

-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/aws-cdk/.projen/tasks.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/aws-cdk/THIRD_PARTY_LICENSES

-7
Original file line numberDiff line numberDiff line change
@@ -10911,13 +10911,6 @@ Apache License
1091110911
See the License for the specific language governing permissions and
1091210912
limitations under the License.
1091310913

10914-
----------------
10915-
10916-
** @jsii/check-node@1.108.0 - https://www.npmjs.com/package/@jsii/check-node/v/1.108.0 | Apache-2.0
10917-
jsii
10918-
Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
10919-
10920-
1092110914
----------------
1092210915

1092310916
** @smithy/abort-controller@4.0.1 - https://www.npmjs.com/package/@smithy/abort-controller/v/4.0.1 | Apache-2.0

‎packages/aws-cdk/lib/cli/cli.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import * as cxapi from '@aws-cdk/cx-api';
2-
import '@jsii/check-node/run';
32
import * as chalk from 'chalk';
43
import { CdkToolkit, AssetBuildTime } from './cdk-toolkit';
54
import { parseCommandLineArguments } from './parse-command-line-arguments';

‎packages/aws-cdk/lib/list-stacks.ts

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
2-
import '@jsii/check-node/run';
31
import { DefaultSelection, ExtendedStackSelection, type StackDetails } from './api/cxapp/cloud-assembly';
42
import { CdkToolkit } from './cli/cdk-toolkit';
53

‎packages/aws-cdk/package.json

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/aws-cdk/test/cli/cli.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ jest.mock('../../lib/logging', () => ({
1313
}));
1414

1515
jest.mock('@aws-cdk/cx-api');
16-
jest.mock('@jsii/check-node/run');
1716
jest.mock('../../lib/cli/platform-warnings', () => ({
1817
checkForPlatformWarnings: jest.fn().mockResolvedValue(undefined),
1918
}));

‎yarn.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.