fix(controller): Fixed broken pprof links #4037 (#4038)

Signed-off-by: Derek Brown <[email protected]>

Author: DerekTBrown

USERS.md

@@ -42,6 +42,7 @@ Organizations below are **officially** using Argo Rollouts. Please send a PR wit
 1. [PagerDuty](https://www.pagerduty.com/)
 1. [PayPal](https://www.paypal.com/)
 1. [PayPay](https://paypay.ne.jp/)
+1. [Plaid](https://plaid.com/)
 1. [Priceline](https://priceline.com)
 1. [Productboard](https://www.productboard.com)
 1. [Quipper](https://www.quipper.com/)

controller/profiling.go

@@ -1,24 +1,21 @@
 package controller
 
 import (
-	"fmt"
 	"net/http"
 	"net/http/pprof"
 )
 
-const (
-	ProfilingPath = "/debug/pprof"
-)
-
 // NewPProfServer returns a new pprof server to gather runtime profiling data
 func NewPProfServer() *http.ServeMux {
 	mux := http.NewServeMux()
 
-	mux.HandleFunc(ProfilingPath, pprof.Index)
-	mux.HandleFunc(fmt.Sprintf("%s/cmdline", ProfilingPath), pprof.Cmdline)
-	mux.HandleFunc(fmt.Sprintf("%s/profile", ProfilingPath), pprof.Profile)
-	mux.HandleFunc(fmt.Sprintf("%s/symbol", ProfilingPath), pprof.Symbol)
-	mux.HandleFunc(fmt.Sprintf("%s/trace", ProfilingPath), pprof.Trace)
+	// TODO: Remove enumerating all pprof endpoints if/when a more ergonomic
+	// attachment solution is introduced. See: https://github.com/golang/go/issues/71213.
+	mux.HandleFunc("/debug/pprof/", pprof.Index)
+	mux.HandleFunc("/debug/pprof/cmdline/", pprof.Cmdline)
+	mux.HandleFunc("/debug/pprof/profile/", pprof.Profile)
+	mux.HandleFunc("/debug/pprof/symbol/", pprof.Symbol)
+	mux.HandleFunc("/debug/pprof/trace/", pprof.Trace)
 
 	return mux
 }