Skip to content

Commit 4611a7d

Browse files
committedDec 4, 2023
refacto: fix paths after pipelines to pipes renaming
1 parent cd57757 commit 4611a7d

File tree

139 files changed

+505
-475
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

139 files changed

+505
-475
lines changed
 

‎contributing.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ We welcome contributions ! There are many ways to help. For example, you can:
44

55
1. Help us track bugs by filing issues
66
2. Suggest and help prioritise new functionalities
7-
3. Develop a new pipeline ! Fork the project and propose a new functionality through a pull request
7+
3. Develop a new pipe ! Fork the project and propose a new functionality through a pull request
88
4. Help us make the library as straightforward as possible, by simply asking questions on whatever does not seem clear to you.
99

1010
## Development installation
1111

12-
To be able to run the test suite, run the example notebooks and develop your own pipeline, you should clone the repo and install it locally.
12+
To be able to run the test suite, run the example notebooks and develop your own pipeline component, you should clone the repo and install it locally.
1313

1414
<div class="termy">
1515

@@ -80,15 +80,15 @@ python -m pytest
8080

8181
Should your contribution propose a bug fix, we require the bug be thoroughly tested.
8282

83-
### Architecture of a pipeline
83+
### Architecture of a pipeline component
8484

85-
Pipelines should follow the same pattern :
85+
Pipes should follow the same pattern :
8686

8787
```
88-
edsnlp/pipelines/<pipeline>
89-
|-- <pipeline>.py # Defines the component logic
88+
edsnlp/pipes/<pipe>
89+
|-- <pipe>.py # Defines the component logic
9090
|-- patterns.py # Defines matched patterns
91-
|-- factory.py # Declares the pipeline to spaCy
91+
|-- factory.py # Declares the component to spaCy
9292
```
9393

9494
### Style Guide

‎demo/app.py

+5-6
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
nlp.add_pipe("eds.normalizer")
4949
nlp.add_pipe("eds.sentences")
5050
{pipes}
51-
# Qualifier pipelines
51+
# Qualifier pipes
5252
nlp.add_pipe("eds.negation")
5353
nlp.add_pipe("eds.family")
5454
nlp.add_pipe("eds.hypothesis")
@@ -109,7 +109,6 @@ def load_model(custom_regex: str, **enabled):
109109
nlp.add_pipe("eds.sentences")
110110

111111
for title, name in PIPES.items():
112-
113112
if name == "drugs":
114113
if enabled["drugs"]:
115114
if enabled["fuzzy_drugs"]:
@@ -128,7 +127,7 @@ def load_model(custom_regex: str, **enabled):
128127
pipes.append(f'nlp.add_pipe("eds.{name}")')
129128

130129
if pipes:
131-
pipes.insert(0, "# Entity extraction pipelines")
130+
pipes.insert(0, "# Entity extraction pipes")
132131

133132
if custom_regex:
134133
nlp.add_pipe(
@@ -169,7 +168,7 @@ def load_model(custom_regex: str, **enabled):
169168
"EDS-NLP is a contributive effort maintained by AP-HP's Data Science team. "
170169
"Have a look at the "
171170
"[documentation](https://aphp.github.io/edsnlp/) for "
172-
"more information on the available pipelines."
171+
"more information on the available components."
173172
)
174173

175174
st.sidebar.header("Pipeline")
@@ -201,8 +200,8 @@ def load_model(custom_regex: str, **enabled):
201200
continue
202201
st_pipes[name] = st.sidebar.checkbox(title, value=True)
203202
st.sidebar.markdown(
204-
"These are just a few of the pipelines provided out-of-the-box by EDS-NLP. "
205-
"See the [documentation](https://aphp.github.io/edsnlp/latest/pipelines/) "
203+
"These are just a few of the components provided out-of-the-box by EDS-NLP. "
204+
"See the [documentation](https://aphp.github.io/edsnlp/latest/pipes/) "
206205
"for detail."
207206
)
208207

0 commit comments

Comments
 (0)
Please sign in to comment.