Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support div_wrapping/rem_wrapping for numeric arithmetic kernels #7158

Closed
wForget opened this issue Feb 20, 2025 · 1 comment · Fixed by #7159
Closed

Support div_wrapping/rem_wrapping for numeric arithmetic kernels #7158

wForget opened this issue Feb 20, 2025 · 1 comment · Fixed by #7159
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@wForget
Copy link
Member

wForget commented Feb 20, 2025

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The div/rem operations may also overflow, so I want to add div_wrapping/rem_wrapping operations to wrapping on overflow. Make it consistent with the logic of add/sub/mul so that we can implement fail_on_overflow feature for div/rem in downstream datafusion. Initially reported in apache/datafusion#14771.

Describe the solution you'd like

add div_wrapping/rem_wrapping operations in numeric arithmetic kernels

Describe alternatives you've considered

Additional context

@wForget wForget added the enhancement Any new improvement worthy of a entry in the changelog label Feb 20, 2025
@alamb alamb added the arrow Changes to the arrow crate label Mar 14, 2025
@alamb
Copy link
Contributor

alamb commented Mar 14, 2025

label_issue.py automatically added labels {'arrow'} from #7159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants