Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msw): adjust combine to handle nested allof #1936

Merged

Conversation

AllieJonsson
Copy link
Contributor

Status

READY

Description

Fix #1895

@soartec-lab Please verify with your various specs :)

Related PRs

List related PRs against other branches:

branch PR
simplify-combine #1815

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct.
Although it is not directly related, it seems that RangeError: Maximum call stack size exceeded has started to occur in my complex OpenAPI since #1882.
We need to fix this separately.

petstoreFile - RangeError: Maximum call stack size exceeded
    at /app/packages/mock/dist/index.js:183:16
    at Array.map (<anonymous>)
    at getMockObject (/app/packages/mock/dist/index.js:159:36)
    at getMockScalar (/app/packages/mock/dist/index.js:419:14)
    at resolveMockValue (/app/packages/mock/dist/index.js:543:21)
    at /app/packages/mock/dist/index.js:665:29
    at Array.reduce (<anonymous>)
    at combineSchemasMock (/app/packages/mock/dist/index.js:647:60)
    at getMockObject (/app/packages/mock/dist/index.js:119:12)
    at getMockScalar (/app/packages/mock/dist/index.js:419:14)

@soartec-lab soartec-lab merged commit 87d5e5e into orval-labs:master Feb 25, 2025
2 checks passed
@soartec-lab soartec-lab added bug Something isn't working msw MSW related issues labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working msw MSW related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSW: mock not properly generated when using allof in allof
2 participants