-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): adjustments to native enums #1882
Merged
soartec-lab
merged 3 commits into
orval-labs:master
from
AllieJonsson:fix/native-enums-2
Feb 8, 2025
Merged
fix(core): adjustments to native enums #1882
soartec-lab
merged 3 commits into
orval-labs:master
from
AllieJonsson:fix/native-enums-2
Feb 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
previously approved these changes
Feb 6, 2025
melloware
approved these changes
Feb 7, 2025
soartec-lab
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
3 tasks
It seems that RangeError: Maximum call stack size exceeded has started to occur in my complex OpenAPI since this PR merged.
We want to create a new version release, so can we revert this PR? |
soartec-lab
added a commit
that referenced
this pull request
Feb 26, 2025
This reverts commit fcd942b.
melloware
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes #1880
This reverts #1860 and instead aims to fix the issue in a better way, by omitting the property in the parent object.
This also fixes issues with faker and native enums.
Todos