fix(core): don't union required with already required props

[AllieJonsson]

Status

READY

Description

Fixes #1877

Previously, /generated/default/all-of/getNotHasPropertiesWithAllOfPets200.ts had this generated code:

export type GetNotHasPropertiesWithAllOfPets200 = Pet &
  PetDetail &
  GetNotHasPropertiesWithAllOfPets200AllOf &
  GetNotHasPropertiesWithAllOfPets200AllOfTwo &
  Required<
    Pick<
      Pet &
        PetDetail &
        GetNotHasPropertiesWithAllOfPets200AllOf &
        GetNotHasPropertiesWithAllOfPets200AllOfTwo,
      'category' | 'color'
    >
  >;

The Required<Pick<..., 'category' | 'color'>> is unnecessary in this case, as both 'category' and 'color' is already required in GetNotHasPropertiesWithAllOfPets200AllOf and GetNotHasPropertiesWithAllOfPets200AllOfTwo.

This PR fixes that and only creates this Required<Pick< when there are non-required properties in a child object that should be required in this top level object. The generated code in /generated/default/all-of/getNotHasPropertiesWithAllOfPets200.ts is now:

export type GetNotHasPropertiesWithAllOfPets200 = Pet &
  PetDetail &
  GetNotHasPropertiesWithAllOfPets200AllOf &
  GetNotHasPropertiesWithAllOfPets200AllOfTwo;

Related PRs

List related PRs against other branches:

branch	PR
require-inside-all-of	#1819

Todos

• Tests
• Documentation
• Changelog Entry (unreleased)

[AllieJonsson]

Is it possible to re-run tests? It seems like there was a network error when installing dependencies :(

[melloware]

I just kicked them off again

[soartec-lab]

@AllieJonsson
I can check before and after the improvement, so could you let me know the test?. Or add it if it does not exist.

[AllieJonsson]

@AllieJonsson I can check before and after the improvement, so could you let me know the test?. Or add it if it does not exist.
It is all-of.yaml

[soartec-lab]

It's great! thanks!