Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mock): ensure getMockScalar respects custom overrides for int64 format #1829

Merged
merged 4 commits into from
Jan 19, 2025

Conversation

matsu3m
Copy link
Contributor

@matsu3m matsu3m commented Jan 17, 2025

Status

READY

Description

Fixes #1828

Although commit 6850e62 is not directly related to fixing the issue, changes were made to enable tests in the mock package.

@matsu3m matsu3m changed the title fix(mock): make sure responseDataType is not empty fix(mock): ensure getMockScalar respects custom overrides for int64 format Jan 17, 2025
@melloware melloware added the mock Related to mock generation label Jan 17, 2025
@soartec-lab soartec-lab added the bug Something isn't working label Jan 19, 2025
Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great fix 🙌

@soartec-lab soartec-lab merged commit 239187b into orval-labs:master Jan 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mock Related to mock generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriding the mock value for properties with format int64 is ignored
3 participants