fix(msw): no more missing properties. support oas31 const #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllieJonsson
commented
Dec 19, 2024
| combine: combine | ||
| ? { | ||
| separator: combine.separator, | ||
| includedProperties: [], |
There was a problem hiding this comment.
The problem was that the linked issue used a anyOf schema where both types has the properties payment_method_id and type. We then saved the includedProperties when traversing down into nested objects, which resulted in the missing properties. I think this is correct, as we don't reset the array, but we still want to be able to add properties of the nested objects.
melloware
approved these changes
Dec 19, 2024
|
nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes #1745
Also adds support for setting constant values using OpenAPI 3.1
constproperty, as used in the schema in the linked issue.