Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: Maybe need to unification the code style by Prettier ? #158

Open
sinoon opened this issue May 3, 2020 · 4 comments
Open

suggestion: Maybe need to unification the code style by Prettier ? #158

sinoon opened this issue May 3, 2020 · 4 comments
Labels
meta Project suggestion and discussion

Comments

@sinoon
Copy link
Contributor

sinoon commented May 3, 2020

No description provided.

@Txiaozhe
Copy link
Collaborator

Txiaozhe commented May 3, 2020

We have eslint yet :(

@sinoon
Copy link
Contributor Author

sinoon commented May 3, 2020

like this type defined of pipelineId and latestSampleData
image

@Txiaozhe
Copy link
Collaborator

Txiaozhe commented May 3, 2020

You could give some advices or help us to fix them:)

@yorkie yorkie added the meta Project suggestion and discussion label May 3, 2020
@yorkie
Copy link
Member

yorkie commented May 3, 2020

@sinoon We have discussed the Prettier integration before, however maintaining 2 sets of rules at the same time is more troublesome, so I have decided to do migrate some Prettier rules to ESLint.

As for the problem that you have pointed out, it's the rule: https://eslint.org/docs/rules/space-infix-ops?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Project suggestion and discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yorkie @sinoon @Txiaozhe