Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add cache for table metadata in TabletServer #320

Open
1 of 2 tasks
luoyuxia opened this issue Jan 13, 2025 · 2 comments · May be fixed by #386
Open
1 of 2 tasks

[Feature] Add cache for table metadata in TabletServer #320

luoyuxia opened this issue Jan 13, 2025 · 2 comments · May be fixed by #386
Assignees
Milestone

Comments

@luoyuxia
Copy link
Collaborator

luoyuxia commented Jan 13, 2025

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Currently, we have no cache for table metadata in TabletServer, every time get metadata request, it'll query from zk and return to client.. Normally, it's serveral milliseconds for getting metadata from zk, but it'll time cost for it when there're many buckets in the table since we'll have to query leader for each bucket..
In my env, for 512 buckets, it cost about 4s...

This problem become worse when start a new job to write job with already running some jobs to write Fluss.. When the new job starts, it'll get metadata which costs serveral seconds and then blocking request queue to degrade the write throughput for the jobs which cause a high latency in a period of time..

Solution

Add a cache for TabletServer to avoid get from zk every time..

Anything else?

No response

Willingness to contribute

  • I'm willing to submit a PR!
@Vipamp
Copy link
Contributor

Vipamp commented Jan 14, 2025

@luoyuxia hi,I'd like to resolve it,i will extract interface MetadataContext for manager metadata and ZK will be an implement,this will prepare for removing ZK in near future

@luoyuxia
Copy link
Collaborator Author

@Vipamp Thanks for attentiion... We already started this work...

@luoyuxia luoyuxia added this to the v0.6 milestone Jan 16, 2025
@luoyuxia luoyuxia self-assigned this Jan 16, 2025
@wuchong wuchong removed the feature label Feb 6, 2025
@wuchong wuchong modified the milestones: v0.6, v0.7 Feb 27, 2025
@wuchong wuchong linked a pull request Mar 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants