Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong results for mapbox when search query has spaces in it #1671

Closed
iBlackShadow opened this issue Dec 4, 2024 · 2 comments · Fixed by #1672
Closed

Wrong results for mapbox when search query has spaces in it #1671

iBlackShadow opened this issue Dec 4, 2024 · 2 comments · Fixed by #1672

Comments

@iBlackShadow
Copy link
Contributor

Hello,

We are getting unexpected results using mapbox when the search query has spaces in it.

For example when the search query is 8626 brookshire ln apt b, st louis MO 63132

Using mapbox's api directly

GET https://api.mapbox.com/geocoding/v5/mapbox.places/8626%20brookshire%20ln%20apt%20b%2C%20st%20louis%20MO%2063132.json?access_token=token

returns

{
	"type": "FeatureCollection",
	"query": [
		"8626",
		"brookshire",
		"ln",
		"apt",
		"b",
		"st",
		"louis",
		"mo",
		"63132"
	],
	"features": [
		{
			"id": "address.7600082562225058",
			"type": "Feature",
			"place_type": [
				"address"
			],
			"relevance": 0.881173,
			"properties": {
				"accuracy": "rooftop",
				"mapbox_id": "dXJuOm1ieGFkcjoxOTJmNDFmMi1mMTMxLTQ4NzMtOTkxOS1hOGFmNmUxMjc5ODg"
			},
			"text": "Brookshire Lane",
			"place_name": "8626 Brookshire Lane, University City, Missouri 63132, United States",
			"center": [
				-90.35829,
				38.66665
			],
			"geometry": {
				"type": "Point",
				"coordinates": [
					-90.35829,
					38.66665
				]
			},
			"address": "8626",
			"context": [
				{
					"id": "postcode.218910444",
					"mapbox_id": "dXJuOm1ieHBsYzpEUXhPN0E",
					"text": "63132"
				},
				{
					"id": "place.334981356",
					"mapbox_id": "dXJuOm1ieHBsYzpFL2RvN0E",
					"wikidata": "Q959885",
					"text": "University City"
				},
				{
					"id": "district.22095596",
					"mapbox_id": "dXJuOm1ieHBsYzpBVkVtN0E",
					"wikidata": "Q498034",
					"text": "St. Louis County"
				},
				{
					"id": "region.271596",
					"mapbox_id": "dXJuOm1ieHBsYzpCQ1Rz",
					"wikidata": "Q1581",
					"short_code": "US-MO",
					"text": "Missouri"
				},
				{
					"id": "country.8940",
					"mapbox_id": "dXJuOm1ieHBsYzpJdXc",
					"wikidata": "Q30",
					"short_code": "us",
					"text": "United States"
				}
			]
		},
		{
			"id": "place.315328748",
			"type": "Feature",
			"place_type": [
				"place"
			],
			"relevance": 0.518519,
			"properties": {
				"mapbox_id": "dXJuOm1ieHBsYzpFc3VJN0E",
				"wikidata": "Q38022"
			},
			"text": "St. Louis",
			"place_name": "St. Louis, Missouri, United States",
			"bbox": [
				-90.512654,
				38.388298,
				-90.11773,
				38.832002
			],
			"center": [
				-90.19835,
				38.627464
			],
			"geometry": {
				"type": "Point",
				"coordinates": [
					-90.19835,
					38.627464
				]
			},
			"context": [
				{
					"id": "district.22087404",
					"mapbox_id": "dXJuOm1ieHBsYzpBVkVHN0E",
					"wikidata": "Q38022",
					"text": "St. Louis city"
				},
				{
					"id": "region.271596",
					"mapbox_id": "dXJuOm1ieHBsYzpCQ1Rz",
					"wikidata": "Q1581",
					"short_code": "US-MO",
					"text": "Missouri"
				},
				{
					"id": "country.8940",
					"mapbox_id": "dXJuOm1ieHBsYzpJdXc",
					"wikidata": "Q30",
					"short_code": "us",
					"text": "United States"
				}
			]
		},
		{
			"id": "district.22087404",
			"type": "Feature",
			"place_type": [
				"district"
			],
			"relevance": 0.518519,
			"properties": {
				"mapbox_id": "dXJuOm1ieHBsYzpBVkVHN0E",
				"wikidata": "Q38022"
			},
			"text": "St. Louis city",
			"place_name": "St. Louis city, Missouri, United States",
			"matching_text": "St. Louis",
			"matching_place_name": "St. Louis, Missouri, United States",
			"bbox": [
				-90.320515,
				38.531852,
				-90.166574,
				38.774431
			],
			"center": [
				-90.19835,
				38.627464
			],
			"geometry": {
				"type": "Point",
				"coordinates": [
					-90.19835,
					38.627464
				]
			},
			"context": [
				{
					"id": "region.271596",
					"mapbox_id": "dXJuOm1ieHBsYzpCQ1Rz",
					"wikidata": "Q1581",
					"short_code": "US-MO",
					"text": "Missouri"
				},
				{
					"id": "country.8940",
					"mapbox_id": "dXJuOm1ieHBsYzpJdXc",
					"wikidata": "Q30",
					"short_code": "us",
					"text": "United States"
				}
			]
		},
		{
			"id": "postcode.218910444",
			"type": "Feature",
			"place_type": [
				"postcode"
			],
			"relevance": 0.49537,
			"properties": {
				"mapbox_id": "dXJuOm1ieHBsYzpEUXhPN0E"
			},
			"text": "63132",
			"place_name": "University City, Missouri 63132, United States",
			"bbox": [
				-90.408972,
				38.66082,
				-90.347838,
				38.696322
			],
			"center": [
				-90.356661,
				38.674083
			],
			"geometry": {
				"type": "Point",
				"coordinates": [
					-90.356661,
					38.674083
				]
			},
			"context": [
				{
					"id": "place.334981356",
					"mapbox_id": "dXJuOm1ieHBsYzpFL2RvN0E",
					"wikidata": "Q959885",
					"text": "University City"
				},
				{
					"id": "district.22095596",
					"mapbox_id": "dXJuOm1ieHBsYzpBVkVtN0E",
					"wikidata": "Q498034",
					"text": "St. Louis County"
				},
				{
					"id": "region.271596",
					"mapbox_id": "dXJuOm1ieHBsYzpCQ1Rz",
					"wikidata": "Q1581",
					"short_code": "US-MO",
					"text": "Missouri"
				},
				{
					"id": "country.8940",
					"mapbox_id": "dXJuOm1ieHBsYzpJdXc",
					"wikidata": "Q30",
					"short_code": "us",
					"text": "United States"
				}
			]
		},
		{
			"id": "neighborhood.450784492",
			"type": "Feature",
			"place_type": [
				"neighborhood"
			],
			"relevance": 0.472531,
			"properties": {
				"mapbox_id": "dXJuOm1ieHBsYzpHdDVzN0E"
			},
			"text": "North St. Louis",
			"place_name": "North St. Louis, St. Louis, Missouri, United States",
			"bbox": [
				-90.267255,
				38.651198,
				-90.210333,
				38.696229
			],
			"center": [
				-90.243996,
				38.653214
			],
			"geometry": {
				"type": "Point",
				"coordinates": [
					-90.243996,
					38.653214
				]
			},
			"context": [
				{
					"id": "postcode.218754796",
					"mapbox_id": "dXJuOm1ieHBsYzpEUW51N0E",
					"text": "63113"
				},
				{
					"id": "place.315328748",
					"mapbox_id": "dXJuOm1ieHBsYzpFc3VJN0E",
					"wikidata": "Q38022",
					"text": "St. Louis"
				},
				{
					"id": "district.22087404",
					"mapbox_id": "dXJuOm1ieHBsYzpBVkVHN0E",
					"wikidata": "Q38022",
					"text": "St. Louis city"
				},
				{
					"id": "region.271596",
					"mapbox_id": "dXJuOm1ieHBsYzpCQ1Rz",
					"wikidata": "Q1581",
					"short_code": "US-MO",
					"text": "Missouri"
				},
				{
					"id": "country.8940",
					"mapbox_id": "dXJuOm1ieHBsYzpJdXc",
					"wikidata": "Q30",
					"short_code": "us",
					"text": "United States"
				}
			]
		}
	],
	"attribution": "NOTICE: © 2024 Mapbox and its suppliers. All rights reserved. Use of this data is subject to the Mapbox Terms of Service (https://www.mapbox.com/about/maps/). This response and the information it contains may not be retained. POI(s) provided by Foursquare."
}

and using Geocoder

Geocoder.search("8626 brookshire ln apt b, st louis MO 63132")
[#<Geocoder::Result::Mapbox:0x00007f08c20ffdd0
  @cache_hit=nil,
  @data=
   {"id"=>"place.315328748",
    "type"=>"Feature",
    "place_type"=>["place"],
    "relevance"=>0.518519,
    "properties"=>{"mapbox_id"=>"dXJuOm1ieHBsYzpFc3VJN0E", "wikidata"=>"Q38022"},
    "text"=>"St. Louis",
    "place_name"=>"St. Louis, Missouri, United States",
    "bbox"=>[-90.512654, 38.388298, -90.11773, 38.832002],
    "center"=>[-90.19835, 38.627464],
    "geometry"=>{"type"=>"Point", "coordinates"=>[-90.19835, 38.627464]},
    "context"=>
     [{"id"=>"district.22087404", "mapbox_id"=>"dXJuOm1ieHBsYzpBVkVHN0E", "wikidata"=>"Q38022", "text"=>"St. Louis city"},
      {"id"=>"region.271596", "mapbox_id"=>"dXJuOm1ieHBsYzpCQ1Rz", "wikidata"=>"Q1581", "short_code"=>"US-MO", "text"=>"Missouri"},
      {"id"=>"country.8940", "mapbox_id"=>"dXJuOm1ieHBsYzpJdXc", "wikidata"=>"Q30", "short_code"=>"us", "text"=>"United States"}]}>,
 #<Geocoder::Result::Mapbox:0x00007f08c20ffad8
  @cache_hit=nil,
  @data=
   {"id"=>"district.22087404",
    "type"=>"Feature",
    "place_type"=>["district"],
    "relevance"=>0.518519,
    "properties"=>{"mapbox_id"=>"dXJuOm1ieHBsYzpBVkVHN0E", "wikidata"=>"Q38022"},
    "text"=>"St. Louis city",
    "place_name"=>"St. Louis city, Missouri, United States",
    "matching_text"=>"St. Louis",
    "matching_place_name"=>"St. Louis, Missouri, United States",
    "bbox"=>[-90.320515, 38.531852, -90.166574, 38.774431],
    "center"=>[-90.19835, 38.627464],
    "geometry"=>{"type"=>"Point", "coordinates"=>[-90.19835, 38.627464]},
    "context"=>
     [{"id"=>"region.271596", "mapbox_id"=>"dXJuOm1ieHBsYzpCQ1Rz", "wikidata"=>"Q1581", "short_code"=>"US-MO", "text"=>"Missouri"},
      {"id"=>"country.8940", "mapbox_id"=>"dXJuOm1ieHBsYzpJdXc", "wikidata"=>"Q30", "short_code"=>"us", "text"=>"United States"}]}>,
 #<Geocoder::Result::Mapbox:0x00007f08c20ff7e0
  @cache_hit=nil,
  @data=
   {"id"=>"postcode.218910444",
    "type"=>"Feature",
    "place_type"=>["postcode"],
    "relevance"=>0.49537,
    "properties"=>{"mapbox_id"=>"dXJuOm1ieHBsYzpEUXhPN0E"},
    "text"=>"63132",
    "place_name"=>"University City, Missouri 63132, United States",
    "bbox"=>[-90.408972, 38.66082, -90.347838, 38.696322],
    "center"=>[-90.356661, 38.674083],
    "geometry"=>{"type"=>"Point", "coordinates"=>[-90.356661, 38.674083]},
    "context"=>
     [{"id"=>"place.334981356", "mapbox_id"=>"dXJuOm1ieHBsYzpFL2RvN0E", "wikidata"=>"Q959885", "text"=>"University City"},
      {"id"=>"district.22095596", "mapbox_id"=>"dXJuOm1ieHBsYzpBVkVtN0E", "wikidata"=>"Q498034", "text"=>"St. Louis County"},
      {"id"=>"region.271596", "mapbox_id"=>"dXJuOm1ieHBsYzpCQ1Rz", "wikidata"=>"Q1581", "short_code"=>"US-MO", "text"=>"Missouri"},
      {"id"=>"country.8940", "mapbox_id"=>"dXJuOm1ieHBsYzpJdXc", "wikidata"=>"Q30", "short_code"=>"us", "text"=>"United States"}]}>,
 #<Geocoder::Result::Mapbox:0x00007f08c20ff4e8
  @cache_hit=nil,
  @data=
   {"id"=>"place.177334508",
    "type"=>"Feature",
    "place_type"=>["place"],
    "relevance"=>0.461728,
    "properties"=>{"mapbox_id"=>"dXJuOm1ieHBsYzpDcEhvN0E", "wikidata"=>"Q959786"},
    "text"=>"Lake Saint Louis",
    "place_name"=>"Lake Saint Louis, Missouri, United States",
    "bbox"=>[-90.843074, 38.741282, -90.746163, 38.80537],
    "center"=>[-90.793076, 38.784515],
    "geometry"=>{"type"=>"Point", "coordinates"=>[-90.793076, 38.784515]},
    "context"=>
     [{"id"=>"district.21808876", "mapbox_id"=>"dXJuOm1ieHBsYzpBVXpHN0E", "wikidata"=>"Q489873", "text"=>"St. Charles County"},
      {"id"=>"region.271596", "mapbox_id"=>"dXJuOm1ieHBsYzpCQ1Rz", "wikidata"=>"Q1581", "short_code"=>"US-MO", "text"=>"Missouri"},
      {"id"=>"country.8940", "mapbox_id"=>"dXJuOm1ieHBsYzpJdXc", "wikidata"=>"Q30", "short_code"=>"us", "text"=>"United States"}]}>,
 #<Geocoder::Result::Mapbox:0x00007f08c20ff1f0
  @cache_hit=nil,
  @data=
   {"id"=>"district.22095596",
    "type"=>"Feature",
    "place_type"=>["district"],
    "relevance"=>0.461728,
    "properties"=>{"mapbox_id"=>"dXJuOm1ieHBsYzpBVkVtN0E", "wikidata"=>"Q498034"},
    "text"=>"St. Louis County",
    "place_name"=>"St. Louis County, Missouri, United States",
    "bbox"=>[-90.73653, 38.388298, -90.11773, 38.891184],
    "center"=>[-90.338277, 38.650259],
    "geometry"=>{"type"=>"Point", "coordinates"=>[-90.338277, 38.650259]},
    "context"=>
     [{"id"=>"region.271596", "mapbox_id"=>"dXJuOm1ieHBsYzpCQ1Rz", "wikidata"=>"Q1581", "short_code"=>"US-MO", "text"=>"Missouri"},
      {"id"=>"country.8940", "mapbox_id"=>"dXJuOm1ieHBsYzpJdXc", "wikidata"=>"Q30", "short_code"=>"us", "text"=>"United States"}]}>]

the first location in the mapbox's result which has a relevance of 0.881173 and is the result we were expecting is missing from the geocoder's resultset.

I forked geocoder's repository to see what is going on and looks like the request geocoder is sending mapbox is slightly different to the one i made.

GET https://api.mapbox.com/geocoding/v5/mapbox.places/8626+brookshire+ln+apt+b%2C+st+louis+MO+63132.json?access_token=pk.eyJ1IjoiZWNkZXZ0ZWFtIiwiYSI6ImNsc2NjYWszMzBvcGcyanFsdTM2YWp0dGgifQ.OdY7n16ZynJcs0MeLvQYhA

spaces were encoded as + by geocoder instead of %20 and thats why the results are different
@iBlackShadow iBlackShadow mentioned this issue Dec 4, 2024
Merged
@iBlackShadow
Copy link
Contributor Author

iBlackShadow commented Dec 4, 2024 •
edited
Loading

according to this stackoverflow post https://stackoverflow.com/questions/1634271/url-encoding-the-space-character-or-20 encoding a space as + is only valid on the query parameter string, otherwise spaces should be encoded as %20.

with this in mind i made some changes to my fork and now i am getting the expected results so i went ahead and opened a PR with my fix

@alexreisner
Copy link
Owner

Thanks! This is excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spaces in a url being encoded as '+' instead of '%20' iBlackShadow/geocoder
2 participants
@alexreisner @iBlackShadow