Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings in companion windows #309

Closed
alexluigit opened this issue Mar 6, 2025 · 2 comments
Closed

Keybindings in companion windows #309

alexluigit opened this issue Mar 6, 2025 · 2 comments

Comments

@alexluigit
Copy link
Owner

Isn't preview in a separate window? If so closing the preview and then
pressing q again to close dirvish should be fine or not? For the other
Emacs modes that's the way the closing mechanism works.

PS: Since you closed this issue, should we open another one for the
keybindings in the preview frame?

Originally posted by @Thaodan in #270

Dirvish restores user's original window configuration after pressing q in the main (root) window, I guess this should also work for preview window as well, as the preview would stop updating once the preview window gets removed. Alternatively, we can bind remap q to other-window locally, which just focus back to the main window.

Another way to handle this would be allowing dirvish-quit (q) command work on all dirvish windows (including root, preview and other misc windows).

@alexluigit alexluigit pinned this issue Mar 6, 2025
@Thaodan
Copy link

Thaodan commented Mar 7, 2025 via email

@alexluigit
Copy link
Owner Author

I'm pinning this issue for a while. If you or anyone have suggestions for commands to bind for these special buffers, please share them here.

@alexluigit alexluigit unpinned this issue Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants