Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'create-react-class' package instead of React.createClass #29

Closed
MichaelDeBoey opened this issue Apr 19, 2017 · 7 comments · Fixed by #31
Closed

Use 'create-react-class' package instead of React.createClass #29

MichaelDeBoey opened this issue Apr 19, 2017 · 7 comments · Fixed by #31

Comments

@MichaelDeBoey
Copy link
Contributor

React.createClass has been deprecated and extracted to it's own package since React v15.5.0.

The following warning is displayed if that version of React is used:
Warning: Highlight: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

See Migrating from React.createClass to fix this.

This could be a temporary fix, but I think moving to ES6 classes is more appropriate :-)

@ivorafael
Copy link

+1

@aroc
Copy link

aroc commented Apr 25, 2017

+1

@lunochkin
Copy link

lunochkin commented May 3, 2017

@MichaelDeBoey
I think this repo isn't under support now.
May be you could create scoped package under your username based on your current version?
https://docs.npmjs.com/getting-started/scoped-packages

@MichaelDeBoey
Copy link
Contributor Author

@maksim-lunochkin I don't have the time to maintain the package, so I don't know if publishing a scoped package would be a good idea. 😕

@lunochkin
Copy link

@MichaelDeBoey I can maintain the package then.
I will take your version as a basis if you don't mind

@MichaelDeBoey
Copy link
Contributor Author

@maksim-lunochkin You can go ahead and use my solution as the basis of your scoped package if you want 🙂

@lunochkin
Copy link

there is scoped package: https://www.npmjs.com/package/@maxlun86/react-highlight

@akiran akiran closed this as completed in #31 May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants