fix units in Geant4FastSimShowerModel::constructSensitives #1088
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaede
changed the title
- units from properties specified in ddsim_steer.py already are in G4units, so no conversion needed
|
If I understand this correctly, we use G4units in ddsim exclusively. Then there should be no conversion applied at all in |
gaede
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Geant4FastSimShowerModel::constructSensitivesGeant4FastSimShowerModel::check_triggerfor fast simulationENDRELEASENOTES
Logically this should be correct:
dd4hep::_toDouble(prop.second)/dd4hep::GeV*CLHEP::GeV- we have a dd4hep property for an energy and need it in Geant4/CLHEP units for GeV. However this is a factor 1000. too large (old code was 1000. too small). @MarkusFrankATcernch Am I missing sth. here ? What is the correct way to convert dd4hep unit to g4 ?