Optimize sensitive detector callbacks in DDG4, Remove deprecated DetElement factories #1079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Optimize sensitive detector callbacks in DDG4.
Many operations were performed twice: once in the sensitive detector, and once again in the computation of
the MC contribution to the hit. This MR removes multiple computations and uses the results from the MC
contribution to create the hit.
The change should be fully compatible and delivers numerically identical results.
Remove deprecated DetElement factories.
To not clutter the global namespace with factory names, factories in the DDDetectors area were declared
deprecated many years ago. At a time these factories were replaced by identical factoris with a name prefix "DD4hep_".
These factories are "official" and should be used instead.
On creation such factories issued a warning message.
It is now time to remove these factories completely.
ENDRELEASENOTES