Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize sensitive detector callbacks in DDG4, Remove deprecated DetElement factories #1079

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

MarkusFrankATcernch
Copy link
Contributor

BEGINRELEASENOTES

  • Optimize sensitive detector callbacks in DDG4.
    Many operations were performed twice: once in the sensitive detector, and once again in the computation of
    the MC contribution to the hit. This MR removes multiple computations and uses the results from the MC
    contribution to create the hit.
    The change should be fully compatible and delivers numerically identical results.

  • Remove deprecated DetElement factories.
    To not clutter the global namespace with factory names, factories in the DDDetectors area were declared
    deprecated many years ago. At a time these factories were replaced by identical factoris with a name prefix "DD4hep_".
    These factories are "official" and should be used instead.
    On creation such factories issued a warning message.
    It is now time to remove these factories completely.

ENDRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor Author

@andresailer @c-dilks
Could you please verify this commit:
4be1f91
I think I have not introduced bugs, but 6 eyes see more than 2....

@andresailer
Copy link
Member

Let's merge #1065 and rebase this one, then at least we have a test covering one of the sensitive detectors.

@MarkusFrankATcernch
Copy link
Contributor Author

@andresailer OK. I leave it then to you to rebase & merge.

@andresailer andresailer self-assigned this Mar 20, 2023
@andresailer
Copy link
Member

Sorry I didn't get around to merging this before! I wanted to have a look at extractContribution in combination with the changes.

Looks all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants