-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple commits. Please see release notes. #1071
Merged
MarkusFrankATcernch
merged 15 commits into
AIDASoft:master
from
MarkusFrankATcernch:master
Mar 3, 2023
Merged
Multiple commits. Please see release notes. #1071
MarkusFrankATcernch
merged 15 commits into
AIDASoft:master
from
MarkusFrankATcernch:master
Mar 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2023
auto-merge was automatically disabled
March 3, 2023 17:56
Rebase failed
88f4e2c
to
77ae6cd
Compare
wdconinc
added a commit
to eic/eic-spack
that referenced
this pull request
Jul 5, 2023
### Briefly, what does this PR introduce? This mainly adds support in AIDASoft/DD4hep#1071, but also some quality of life changes in AIDASoft/DD4hep#1106. The rest are dependencies for patch context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
(See isue: Impossible to include plugin definitions from an external XML file #1062).
The corresponding examples are:
-- minitel_config_plugins_include_command_line, which shows how to perform the task by parsing sequentially the
XML input files like:
-- minitel_config_plugins_include_command_xml, where the second XML file is simply included:
where
BoxTrafos
is the entire original XML containing the geometry.Can be used directly to modify the settings of s DetElement identified by its path. Similar for sensitive detector objects:
This construct also allows to configure the world volume as part of the resolution of issue How to define a
limitset
applicable to the whole world? #1064Technically the implementation are XML utilities, which are used both by the plugin and the Compact converter.
Propagate the changes to the world volume to Geant4, which was not possible with DDG4 before, because production cuts and region settings for the world volume belong to Geant4 and are managed by Geant4. (also How to define a
limitset
applicable to the whole world? #1064)Side product: Add debug flags for the G4 LimitSet conversion. To enable the flags in the python setup:
Have the maps in DetectorData being named to ease debugging.
Add some XML attribute conversions (more user friendliness)
Add accessors to the PlacedVolume and the Volume handles to access the class name of the implementing class.
DDDigi: Add passing event parameters to the output and from the input record to the store. Needs testing though,
but this requires a new release of podio.
ENDRELEASENOTES