Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addendum to PR https://github.com/AIDASoft/DD4hep/pull/1068 #1070

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Addendum to PR https://github.com/AIDASoft/DD4hep/pull/1068 #1070

merged 2 commits into from
Mar 2, 2023

Conversation

MarkusFrankATcernch
Copy link
Contributor

@MarkusFrankATcernch MarkusFrankATcernch commented Mar 1, 2023 •
edited by andresailer
Loading

BEGINRELEASENOTES

  • PR 1068 was incomplete (OpticalTracker). Add the missing pieces.
    ENDRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor Author

@c-dilks
Could you please verify this PR ? If this is OK, I shall start thinking about the SD callback simplifications.
Thsnks a lot!

@c-dilks
Copy link
Contributor

c-dilks commented Mar 2, 2023

Thanks! I tested this branch with examples/OpticalTracker, and everything looks good. In fact, now the g4ID branch is filled too (previously that was also always zero). All distributions look consistent with the initial version of OpticalTracker.

@MarkusFrankATcernch
Copy link
Contributor Author

@c-dilks Thanks a lot for testing! This was very useful.
I will probably ask you again for the favor of cross-checking the code once I have optimized the
computations in the sensitive detectors.

@MarkusFrankATcernch MarkusFrankATcernch merged commit 05e52a6 into AIDASoft:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkusFrankATcernch @c-dilks