Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add energy deposition test for OpticalTracker example #1065

Merged
merged 2 commits into from
Mar 21, 2023
Merged

feat: add energy deposition test for OpticalTracker example #1065

merged 2 commits into from
Mar 21, 2023

Conversation

c-dilks
Copy link
Contributor

@c-dilks c-dilks commented Mar 1, 2023 •
edited
Loading

BEGINRELEASENOTES

  • Add test for average energy deposition in OpticalTracker example, for Geant4SensitiveAction<Geant4OpticalTracker>

ENDRELEASENOTES

@c-dilks c-dilks mentioned this pull request Mar 1, 2023
Closed
@c-dilks c-dilks force-pushed the test-opticaltracker-edep branch 2 times, most recently from 2cf3590 to d68d449 Compare March 2, 2023 20:59
@c-dilks c-dilks marked this pull request as ready for review March 2, 2023 21:00
@c-dilks
Copy link
Contributor Author

c-dilks commented Mar 2, 2023

This test should pass now, since #1067 is resolved.

@c-dilks
Copy link
Contributor Author

c-dilks commented Mar 2, 2023 •
edited
Loading

Hmm... I'm not sure how to correctly handle units in the test. The key4hep job does not have access to CLHEP units, and at least in my local build, dd4hep::eV != CLHEP::eV. In the simulation output ROOT file, it looks like the energy units are in MeV.

@andresailer andresailer force-pushed the test-opticaltracker-edep branch from d68d449 to 72a90e9 Compare March 9, 2023 12:47
@c-dilks
Copy link
Contributor Author

c-dilks commented Mar 9, 2023

Oh, thanks @andresailer! Sorry I got distracted working on other things...

@c-dilks c-dilks requested a review from andresailer March 10, 2023 19:20
@andresailer andresailer force-pushed the test-opticaltracker-edep branch from 72a90e9 to 0e633d3 Compare March 20, 2023 13:21
@andresailer andresailer mentioned this pull request Mar 20, 2023
Merged
@andresailer andresailer merged commit c837b83 into AIDASoft:master Mar 21, 2023
@c-dilks c-dilks deleted the test-opticaltracker-edep branch March 21, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-dilks @andresailer