src/asyncLocalStorage.ts

@@ -1,3 +1,5 @@
+// using istanbul ignore on portions of code that are not currently used internally
+
 interface IAsyncLocalStorage {
   clear(): Promise<void>
   getItem(key: string): Promise<string>
@@ -6,25 +8,26 @@ interface IAsyncLocalStorage {
 }
 
 export const AsyncLocalStorage: IAsyncLocalStorage = {
-  // istanbul ignore clear and removeItem as they're not currently used internally
+  // must use wrapper functions when passing localStorage functions (https://github.com/agilgur5/mst-persist/issues/18)
   clear /* istanbul ignore next */ () {
-    return callWithPromise(window.localStorage.clear)
+    return callWithPromise(() => window.localStorage.clear())
   },
   getItem (key) {
-    return callWithPromise(window.localStorage.getItem, key)
+    return callWithPromise(() => window.localStorage.getItem(key))
   },
   removeItem /* istanbul ignore next */ (key) {
-    return callWithPromise(window.localStorage.removeItem, key)
+    return callWithPromise(() => window.localStorage.removeItem(key))
   },
   setItem (key, value) {
-    return callWithPromise(window.localStorage.setItem, key, value)
+    return callWithPromise(() => window.localStorage.setItem(key, value))
   }
 }
 
 function callWithPromise (func: Function, ...args: any[]): Promise<any> {
   try {
     return Promise.resolve(func(...args))
   } catch (err) {
+    /* istanbul ignore next */
     return Promise.reject(err)
   }
 }

src/index.ts

@@ -14,7 +14,7 @@ export interface IOptions {
 type StrToAnyMap = {[key: string]: any}
 
 export const persist: IArgs = (name, store, options = {}) => {
-  let {storage, jsonify, whitelist, blacklist} = options
+  let {storage, jsonify = true, whitelist, blacklist} = options
 
   // use AsyncLocalStorage by default (or if localStorage was passed in)
   if (
@@ -30,7 +30,6 @@ export const persist: IArgs = (name, store, options = {}) => {
       'engine via the `storage:` option.')
   }
 
-  if (!jsonify) { jsonify = true } // default to true like mobx-persist
   const whitelistDict = arrToDict(whitelist)
   const blacklistDict = arrToDict(blacklist)
 

test/index.spec.ts

@@ -47,7 +47,7 @@ describe('persist options', () => {
 
     user.changeName('Joe') // fire action to trigger onSnapshot
     // if not jsonified, localStorage will store as '[object Object]'
-    expect(window.localStorage.getItem('user')).toStrictEqual('[object Object]')
+    expect(window.localStorage.getItem('user')).toBe('[object Object]')
   })
 
   it('should whitelist', async () => {