Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rom generator fails when layout contains collection elements #3

Open
goldenegg opened this issue Jun 27, 2023 · 5 comments
Open

Rom generator fails when layout contains collection elements #3

goldenegg opened this issue Jun 27, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@goldenegg
Copy link

Version (or build number)

0.1.0

Platform (Pocket or MiSTer)

N/A

Steps to reproduce

Run ROM generator with the syntax from the documentation against a MAME .250 merged romset.

Expected Behavior

No response

Actual Behavior

Running the ROM generator on Windows and Mac both result in the same error.

C:\Users\goldenegg\windows>fpga-gnw-romgenerator.exe --mame-path e:\mametemp --output-path e:\output supported

Processing device gnw_ball

thread 'main' panicked at 'called Result::unwrap() on an Err value: Custom { field: "unknown variant collection, expected one of bounds, element, screen" }', src\layout.rs:139:80

Additional Context

Confirmed that the required ROMs and artwork are present. The required files can be extracted manually.

@goldenegg goldenegg added the bug Something isn't working label Jun 27, 2023
@agg23
Copy link
Owner

agg23 commented Jun 27, 2023

Interesting. Would you happen to be using an alternative artwork?

Could you please attach the default.lay file from your artwork zip?

@goldenegg
Copy link
Author

Correction. It's a MAME 0.251 romset being used.

@goldenegg
Copy link
Author

default.lay.zip

It's a standard artwork files from the 0.250 extras set.

@goldenegg
Copy link
Author

goldenegg commented Jun 27, 2023

I got an artwork set from another source and ROM generator worked. Not sure why the files from what's supposed to be the official set aren't working. I'll raise it with their team, but I'll leave it to you whether or not you want to close this ticket.

@agg23
Copy link
Owner

agg23 commented Jun 27, 2023

This is a really weird layout. It's completely different than all other's I've seen, and it even uses completely different "View" names (the different user-selectable ways of presenting the layers of the image) than the rest of the artwork, so my tool would be unable to accurately choose the correct view.

I should support this, but it's not going to be trivial work. It's probably not going to happen soon.

@agg23 agg23 changed the title Rom generator fails with "panicked at 'called Result::unwrap()" Rom generator fails when layout contains collection elements Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants