-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSF #12
Comments
I already said similar things in the joint-crab repo, but I will repeat it here. I think for the that paper we don't want to add more information. That data will be publicly released, so we would need to validate the whole 3D analysis chain... Of course don't get me wrong, internally we need to implement the full-enclosure IRFs for scientific reasons... So this definitely needs to be done. |
Agree - this is a goal for down the line, we want this in place before we release VEGAS 2.6.0 though since it make sense to only run the EAs once (or at least we want the VEGAS bit in place - the V2DL3 bit will be the easy one!). |
I have some preliminary implementation in a VEGAS branch for full enclosure IRF. I follow the same implementation as that of ED and included the following new histogram:
I think the angular difference histogram already serve as what we want here. |
Save PSF to EA file and then record it in the DL3 file.
The text was updated successfully, but these errors were encountered: