Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSF #12

Open
ralphbird opened this issue Jul 11, 2018 · 3 comments
Open

PSF #12

ralphbird opened this issue Jul 11, 2018 · 3 comments
Labels
enhancement New feature or request VEGAS Specific to the VEGAS branch

Comments

@ralphbird
Copy link

Save PSF to EA file and then record it in the DL3 file.

@ralphbird ralphbird added the enhancement New feature or request label Jul 11, 2018
@ralphbird ralphbird self-assigned this Jul 11, 2018
@TarekHC
Copy link
Collaborator

TarekHC commented Jul 12, 2018

I already said similar things in the joint-crab repo, but I will repeat it here.

I think for the that paper we don't want to add more information. That data will be publicly released, so we would need to validate the whole 3D analysis chain...

Of course don't get me wrong, internally we need to implement the full-enclosure IRFs for scientific reasons... So this definitely needs to be done.

@ralphbird
Copy link
Author

Agree - this is a goal for down the line, we want this in place before we release VEGAS 2.6.0 though since it make sense to only run the EAs once (or at least we want the VEGAS bit in place - the V2DL3 bit will be the easy one!).

@tony32lin
Copy link
Collaborator

I have some preliminary implementation in a VEGAS branch for full enclosure IRF. I follow the same implementation as that of ED and included the following new histogram:

  1. pfEffArea_MC_no_theta_cut
    Effective Area (MC Energy) without theta^2 cut
  2. pfEnergyBias_2D_DL3
    DL3 style energy bias E_{rec}/E_{real} vs MC Energy
  3. pfEnergyBias_2D_DL3_no_theta_cut
    DL3 style energy bias E_{rec}/E_{real} vs MC Energy (no theta^2 cut)
  4. pfLogAngularBias_2D_DL3_no_theta_cut
    Log10(Angular difference (rec - real) ) vs MC Energy

I think the angular difference histogram already serve as what we want here.
See below for an example of such histogram at 0deg zenith angle using Moderate cut.
screen shot 2019-01-03 at 5 30 44 pm

@ralphbird ralphbird removed their assignment May 27, 2021
@GernotMaier GernotMaier added the VEGAS Specific to the VEGAS branch label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request VEGAS Specific to the VEGAS branch
Projects
None yet
Development

No branches or pull requests

4 participants