zzzprojects#769 - SlidingCache Test Code-Comment Cleanup

Author: Travis Whidden

test/System.Linq.Dynamic.Core.Tests/Util/Cache/SlidingCacheTests.cs

@@ -15,6 +15,7 @@ public class SlidingCacheTests
     public void SlidingCache_CacheOperations()
     {
         var dateTimeUtilsMock = new Mock<IDateTimeUtils>();
+        // Configure Mock with SetupGet since SlidingCache can be non-deterministic; don't use SetupSequence
         dateTimeUtilsMock.SetupGet(d => d.UtcNow).Returns(UtcNow);
 
         // Arrange
@@ -46,6 +47,7 @@ public void SlidingCache_CacheOperations()
     public void SlidingCache_TestExpire()
     {
         var dateTimeUtilsMock = new Mock<IDateTimeUtils>();
+        // Configure Mock with SetupGet since SlidingCache can be non-deterministic; don't use SetupSequence
         dateTimeUtilsMock.SetupGet(d => d.UtcNow).Returns(UtcNow);
 
         // Arrange
@@ -55,19 +57,19 @@ public void SlidingCache_TestExpire()
         // Act
         cache.AddOrUpdate(1, "one");
 
+        // move the time forward 
         var newDateTime = dateTimeUtilsMock.Object.UtcNow.AddMinutes(11);
         dateTimeUtilsMock.SetupGet(d => d.UtcNow).Returns(newDateTime);
 
-        if (cache.TryGetValue(1, out var value))
-        {
-            Assert.True(false, $"Expected to not find the value, but found {value}");
-        }
+        // Ensure that the element has expired
+        cache.TryGetValue(1, out var value).Should().BeFalse($"Expected to not find the value, but found {value}");
     }
 
     [Fact]
     public void SlidingCache_TestReturnExpiredItems()
     {
         var dateTimeUtilsMock = new Mock<IDateTimeUtils>();
+        // Configure Mock with SetupGet since SlidingCache can be non-deterministic; don't use SetupSequence
         dateTimeUtilsMock.SetupGet(d => d.UtcNow).Returns(UtcNow);
 
         // Arrange
@@ -77,7 +79,7 @@ public void SlidingCache_TestReturnExpiredItems()
         // Act
         cache.AddOrUpdate(1, "one");
 
-        // move the time forward
+        // move the time forward 
         var newDateTime = dateTimeUtilsMock.Object.UtcNow.AddMinutes(11);
         dateTimeUtilsMock.SetupGet(d => d.UtcNow).Returns(newDateTime);
 
@@ -89,6 +91,7 @@ public void SlidingCache_TestReturnExpiredItems()
     public void SlidingCache_TestAutoExpire()
     {
         var dateTimeUtilsMock = new Mock<IDateTimeUtils>();
+        // Configure Mock with SetupGet since SlidingCache can be non-deterministic; don't use SetupSequence
         dateTimeUtilsMock.SetupGet(d => d.UtcNow).Returns(UtcNow);
 
         // Arrange
@@ -131,6 +134,7 @@ public void SlidingCache_TestNull()
     public void SlidingCache_TestMinNumberBeforeTests()
     {
         var dateTimeUtilsMock = new Mock<IDateTimeUtils>();
+        // Configure Mock with SetupGet since SlidingCache can be non-deterministic; don't use SetupSequence
         dateTimeUtilsMock.SetupGet(d => d.UtcNow).Returns(UtcNow);
 
         // Arrange