You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seeing renovate failing Flutter analyze with two warnings led me to discover the use of the deprecated RouteInformation.location as well as an non-deprecated override of WidgetsBindingObserver.didPushRoute(). I believe we should fix this with the goal of accomplishing the following:
Prevent flutter analyze from blocking renovate's PR:s
Move on from deprecated methods/properties ahead of removal.
Enable Stacked to make use of the benefits and fixes connected to the move from location to uri.
I suggest the following requirements.
Change all private uses of the location paramter to use the uri parameter.
Deprecate the location parameter in all public methods that has it.
Add uri parameter to all public methods with a location parameter with an either or assert as well as logic to handle both cases.
Deprecate the didPushRoute() @override in StackedRouteInformationProvider
What operating system do you use?
Windows
Information about the installed tooling
No response
Steps to reproduce the issue
Fork repo
Run: flutter analyze
Expected behavior
flutter analyze not giving any warnings
Screenshots
No response
Additional Context
Unsure if this should be reported as a feature or bug. I've started working on a PR (link here shortly). For more context check out this PR where location was deprecated (and also mentions it being made non-nullable): flutter/flutter#119968
The text was updated successfully, but these errors were encountered:
Describe the bug
Seeing renovate failing Flutter analyze with two warnings led me to discover the use of the deprecated RouteInformation.location as well as an non-deprecated override of WidgetsBindingObserver.didPushRoute(). I believe we should fix this with the goal of accomplishing the following:
I suggest the following requirements.
What operating system do you use?
Windows
Information about the installed tooling
No response
Steps to reproduce the issue
Expected behavior
flutter analyze not giving any warnings
Screenshots
No response
Additional Context
Unsure if this should be reported as a feature or bug. I've started working on a PR (link here shortly). For more context check out this PR where location was deprecated (and also mentions it being made non-nullable): flutter/flutter#119968
The text was updated successfully, but these errors were encountered: