Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Fix deprecations: RouteInformation.location #1145

Open
4 tasks
Pebkac03 opened this issue Dec 10, 2024 · 1 comment
Open
4 tasks

[bug]: Fix deprecations: RouteInformation.location #1145

Pebkac03 opened this issue Dec 10, 2024 · 1 comment
Labels

Comments

@Pebkac03
Copy link
Contributor

Pebkac03 commented Dec 10, 2024

Describe the bug

Seeing renovate failing Flutter analyze with two warnings led me to discover the use of the deprecated RouteInformation.location as well as an non-deprecated override of WidgetsBindingObserver.didPushRoute(). I believe we should fix this with the goal of accomplishing the following:

  1. Prevent flutter analyze from blocking renovate's PR:s
  2. Move on from deprecated methods/properties ahead of removal.
  3. Enable Stacked to make use of the benefits and fixes connected to the move from location to uri.

I suggest the following requirements.

  • Change all private uses of the location paramter to use the uri parameter.
  • Deprecate the location parameter in all public methods that has it.
  • Add uri parameter to all public methods with a location parameter with an either or assert as well as logic to handle both cases.
  • Deprecate the didPushRoute() @​override in StackedRouteInformationProvider

What operating system do you use?

Windows

Information about the installed tooling

No response

Steps to reproduce the issue

  1. Fork repo
  2. Run: flutter analyze

Expected behavior

flutter analyze not giving any warnings

Screenshots

No response

Additional Context

Unsure if this should be reported as a feature or bug. I've started working on a PR (link here shortly). For more context check out this PR where location was deprecated (and also mentions it being made non-nullable): flutter/flutter#119968

@FilledStacks
Copy link
Contributor

Much appreciated @Pebkac03 , I've taken the shortcut on this matter and disabled analyze as a failure step in the workflow.

The main reason being we just need the tests to pass in order for us to feel confident that the package works as expected.

We can still fix the deprecation issues soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants