Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc issue] Localization of UI Texts #113

Closed
ProFreak opened this issue Mar 5, 2024 · 4 comments
Closed

[doc issue] Localization of UI Texts #113

ProFreak opened this issue Mar 5, 2024 · 4 comments
Assignees
Labels
follow-up-with/dev Clarification with development needed. not-doc-issue Reported issue is not a documentation issue. SAP Fiori elements

Comments

@ProFreak
Copy link

ProFreak commented Mar 5, 2024

Issue description

Edit: correction of the typo in "sap-language"

Hello,

I have noticed an issue with the ABAP CDS Localization of UI Texts.
It is about the following SAP documentation :

I have tried to implement it as described an I am using a List Report to display some demo data from the new flight data model.

I defined the line item in a Metadata Extension file:
@UI.lineItem: [{position: 70, label: '{i18n>TotalPrice}'}] TotalPrice;

And added the key-value pair into the i18n.properties file.
To this point, everything works perfectly fine.

But when i add another i18 file, in my example for the german langauge e.g. i18n_de.properties the language specific Text is not read and the standard sap-label (if existent) or the datafield name is shown wen loding the app in the preview (BTP BAS) with url parameter sap-language=de .

Changes to the app title are working fine. And the text is availiable in the networktab in the Browser DevTools. So I think this is an issue with the SAPUI5 Framework...

My expectation would be, that the localization via CDS annotation is also working for every other langauge file. Otherwise this way of implementation would not make sense.

Feedback Type (Optional)

other

Page Title on SAP Help Portal (prefilled)

Localization of UI Texts

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/b8cb649973534f08a6047692f8c6830d

@KvM2 KvM2 added follow-up-with/dev Clarification with development needed. SAP Fiori elements labels Mar 5, 2024
@KvM2
Copy link
Contributor

KvM2 commented Mar 5, 2024

Hi @ProFreak , thanks for your contribution . We appreciate it and will look into this.

@JannaLisa JannaLisa self-assigned this Mar 15, 2024
@JannaLisa
Copy link
Contributor

Hello @ProFreak,
my architect and I have checked your question.
First of all, this is not a documentation issue ;-) The feature is supported across all languages.
Then, we noticed a typo in the URL parameter for German ("wen loding the app in the preview (BTP BAS) with url parameter sap-langauge=de") - could that be part of the issue?
Since to investigate further, our developers would require you to share some code, we would like to direct you to https://answers.sap.com/index.html . Please post your question there, since it is a technical environment where experts can support you.
Hopefully your query can be answered there.
Thanks!

@ProFreak
Copy link
Author

Hello @JannaLisa,

unfortunately the typo in my text is not the reason 😄. I did it correct in the URL.
I also tried adding an "@" in '{**@**i18n>TotalPrice}".
I will post my question there, thanks for the Information and confirmation that I ain't alone with my expectation.

@JannaLisa
Copy link
Contributor

Hi @ProFreak ,
thanks, I hope our technical experts will be able to help you.
I'm closing the issue here since we agree it's not a documentation-related issue.
All the best!

@JannaLisa JannaLisa added the not-doc-issue Reported issue is not a documentation issue. label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up-with/dev Clarification with development needed. not-doc-issue Reported issue is not a documentation issue. SAP Fiori elements
Projects
None yet
Development

No branches or pull requests

4 participants