Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should specify that the internal data structure used is bi-partite FG (in the developer's documentation) #237

Closed
bvdmitri opened this issue May 29, 2024 · 0 comments · Fixed by #253
Assignees

Comments

@bvdmitri
Copy link
Member

It might lead to a confusion, especially when we will have the visualisation in a form of FFG. The internal data structures do not use FFG representation for efficiency. But in many places we mention FFG and people get confused, I think we should clarify that. (Also in RxInfer).

On the surface, I think we should just say factor graphs, instead of Forney-style factor graphs. For users it doesn't really change much since we can visualize an arbitrary FG as an FFG, but for the developers who actively work with the code it may reduce the confusion.

@wouterwln wouterwln linked a pull request Sep 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants